-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alpha globals flag "--log_dir" in config.json is inoperative #2854
Comments
Although it’s not obvious, this is the expected behavior. The log flags like To prevent log files from being written and only writing to stderr, you can use the |
That means --config can't use all flag . |
This PR fixes hypermodeinc#2854 Why glog can't use values set in config file? glog reads values from flags. When a user sets the value (of a glog flag) in a config file, glog doesn't recognize it because the flag value hasn't changed. How does this PR fix it? With this PR, we set the value of glog flags from the values in config file. Note: This is a hack. glog doesn't allow setting configuration programatically and thus we have to use this hack. Signed-off-by: Ibrahim Jarif <[email protected]>
* Set glog flags from configuration This PR fixes #2854 Why glog can't use values set in config file? glog reads values from flags. When a user sets the value (of a glog flag) in a config file, glog doesn't recognize it because the flag value hasn't changed. How does this PR fix it? With this PR, we set the value of glog flags from the values in config file. Note: This is a hack. glog doesn't allow setting configuration programatically and thus we have to use this hack. Signed-off-by: Ibrahim Jarif <[email protected]> * Fix error check Signed-off-by: Ibrahim Jarif <[email protected]> * Fix line length Signed-off-by: Ibrahim Jarif <[email protected]>
* Set glog flags from configuration This PR fixes hypermodeinc#2854 Why glog can't use values set in config file? glog reads values from flags. When a user sets the value (of a glog flag) in a config file, glog doesn't recognize it because the flag value hasn't changed. How does this PR fix it? With this PR, we set the value of glog flags from the values in config file. Note: This is a hack. glog doesn't allow setting configuration programatically and thus we have to use this hack. Signed-off-by: Ibrahim Jarif <[email protected]> * Fix error check Signed-off-by: Ibrahim Jarif <[email protected]> * Fix line length Signed-off-by: Ibrahim Jarif <[email protected]>
If you suspect this could be a bug, follow the template.
Have you tried reproducing the issue with latest release?
yes
What is the hardware spec (RAM, OS)?
64G
Steps to reproduce the issue (command/config used to run Dgraph).
-- cmd:
--alpha.json
In this scene , expect all logs are writed "/home/s/dgraph/logs" instead of "/tmp" .
The text was updated successfully, but these errors were encountered: