Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fatal error: concurrent map writes #2849

Closed
selmeci opened this issue Dec 28, 2018 · 5 comments
Closed

fatal error: concurrent map writes #2849

selmeci opened this issue Dec 28, 2018 · 5 comments
Assignees
Labels
kind/bug Something is broken.

Comments

@selmeci
Copy link
Contributor

selmeci commented Dec 28, 2018

If you suspect this could be a bug, follow the template.

  • What version of Dgraph are you using?
    v1.0.11

  • Have you tried reproducing the issue with latest release?
    yes

  • What is the hardware spec (RAM, OS)?
    AWS EC2 r5d.2xlarge, 64GB RAM, SSD disk.

  • Steps to reproduce the issue (command/config used to run Dgraph).
    It looks same as already reported bug in this issue.
    Here is logs from alpha.

  • Expected behaviour and actual result.
    Alpha does not crush.

@manishrjain manishrjain added the kind/bug Something is broken. label Dec 28, 2018
@manishrjain
Copy link
Contributor

The other issue is a different one. This is caused by some optimizations I made, allowing processing a particular section of the query concurrently.

@selmeci
Copy link
Contributor Author

selmeci commented Dec 30, 2018

Any ETA for hotfix at least in master branch? Right now alpha is really unstable because I can not predict which query will crush. Unfortunately we are already launched dGraph in production environment.

@manishrjain manishrjain self-assigned this Dec 30, 2018
@manishrjain
Copy link
Contributor

Can you build a binary from mrjn/concurrent-facet branch? I pushed a change which I think should solve this issue. Let me know if it works, and I'll push it to master.

@selmeci
Copy link
Contributor Author

selmeci commented Dec 31, 2018

Thanks for quick response! I built docker image with this dockerfile:

FROM golang

RUN mkdir -p /dgraph/plugins
COPY tokenizer/nfd.go /dgraph/plugins
# build dgraph
RUN \
    go get -v github.com/dgraph-io/dgraph/dgraph && \
    cd /go/src/github.com/dgraph-io/dgraph/ && \
    git fetch --all --tags --prune && \
    git checkout mrjn/concurrent-facet && \
    cd dgraph/ && \
    go build && \
    chmod a+x dgraph && \
    mv dgraph /usr/local/bin/dgraph && \
    cd /dgraph/plugins && \
    go build -buildmode=plugin -o nfd.so ./nfd.go && \
    rm ./nfd.go && \
    rm -r /go/src/*

EXPOSE 9080
EXPOSE 8080
EXPOSE 6080
EXPOSE 5080

VOLUME /dgraph

WORKDIR /dgraph

Alpha is stable and does not stop with fatal error: concurrent map writes but it stop with OOM - consume 16GB of RAM. I had to switch back to v1.0.10 where everything is working - same script finish withi no OOM and no concurrent error.

@selmeci
Copy link
Contributor Author

selmeci commented Dec 31, 2018

I have already reported possible OOM issue with profiles in discuss topic https://discuss.dgraph.io/t/is-there-oom-issue-in-v1-0-11/3792

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something is broken.
Development

No branches or pull requests

2 participants