Handle various edge cases around cluster memberships. #2791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Nov 29, 2018
dgraph/cmd/zero/zero.go
Outdated
| errUpdatedMember = errors.New("Cluster member has updated credentials.") | ||
| errServerShutDown = errors.New("Server is being shut down.") | ||
| // errUnknownMember = errors.New("Unknown cluster member") | ||
| errUpdatedMember = errors.New("Cluster member has updated credentials.") |
There was a problem hiding this comment.
errUpdatedMember is unused (from varcheck)
| // removing a freshly added node. | ||
| for _, member := range g.state.Removed { | ||
| if member.GroupId == g.Node.gid && g.Node.AmLeader() { | ||
| go g.Node.ProposePeerRemoval(context.Background(), member.Id) |
There was a problem hiding this comment.
Error return value of g.Node.ProposePeerRemoval is not checked (from errcheck)
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
- We had a bug where we'll infinite remove and connect to an address which is present in both active nodes and removed nodes. This PR checks for active nodes first, before removing a connection. - Make the errors a lot more descriptive. Use a unique string to determine when a node must crash, due to permanent failures. Refactor those conditions out in `x.ShouldCrash`. - Removing a live node using `/removeNode` should now automatically crash that node, and cause others to remove the connection to that node, which is convenient. - Trying to connect using the same ID or the same Address (while prev conn is valid), would also crash the new process (wanted behavior). - If Zero already has a member set for a given Address (and ID=0), it would return the member info directly, instead of proposing first. In general, this PR handles a bunch of edge cases and bugs around membership.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is