Do not retry proposal if already found in CommittedEntries #2740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
…#2740) This is the first win from Open Census. Learnt that proposals immediately show up in `raft.Ready().CommittedEntries`, but then take a long time in the `applyCh` queue to be applied. If these proposals are just waiting in the queue to be applied, then we're sure that Raft didn't lose them in flight, and therefore, we don't need to re-propose them. This PR detects that and avoids retrying the proposal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first win from Open Census. Learnt that proposals immediately show up in
raft.Ready().CommittedEntries, but then take a long time in theapplyChqueue to be applied. If these proposals are just waiting in the queue to be applied, then we're sure that Raft didn't lose them in flight, and therefore, we don't need to re-propose them. This PR detects that and avoids retrying the proposal.This change is