Restore schema states on error, and fixing flaky test #2730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Nov 7, 2018
worker/mutation.go
Outdated
| @@ -97,6 +97,8 @@ func runMutation(ctx context.Context, edge *pb.DirectedEdge, txn *posting.Txn) e | |||
| // and further mutations are blocked until this is done. | |||
| func runSchemaMutation(ctx context.Context, update *pb.SchemaUpdate, startTs uint64) error { | |||
| if err := runSchemaMutationHelper(ctx, update, startTs); err != nil { | |||
| // on error, we restore the memory state to be the same as the disk | |||
| schema.Load(update.Predicate) | |||
There was a problem hiding this comment.
Error return value of schema.Load is not checked
manishrjain
approved these changes
Nov 8, 2018
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @golangcibot and @gitlw)
worker/mutation.go, line 108 at r3 (raw file):
if loadErr != nil { glog.Errorf("failed to load schema after %d retries: %v", maxRetries, loadErr)
glog.Fatalf
added 6 commits
November 8, 2018 14:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2654 fixes #2717
Tested with test.sh
This change is