Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed OOR values in query parser. #2690

Merged
merged 1 commit into from
Oct 24, 2018

Conversation

srfrog
Copy link
Contributor

@srfrog srfrog commented Oct 24, 2018

The query parser was ignoring out of range errors for large
uint values, such as uids. Also, the parseID function was
returning values along with errors.

Closes #2689


This change is Reviewable

The query parser was ignoring out of range errors for large
uint values, such as uids. Also, the parseID function was
returning values along with errors.

Closes #2689
Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Nice change!

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@srfrog srfrog merged commit ee3a6d0 into master Oct 24, 2018
@srfrog srfrog deleted the feature/issue-2689_error_message_is_misleading branch October 24, 2018 16:27
dna2github pushed a commit to dna2fork/dgraph that referenced this pull request Jul 19, 2019
The query parser was ignoring out of range errors for large
uint values, such as uids. Also, the parseID function was
returning values along with errors.

Closes dgraph-io#2689
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants