Bug fix: Send commit timestamps in order #2687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Oct 22, 2018
…tiple updates from Zero.
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
Zero had a race condition, where it could send commit timestamps out of order. This can cause invalid reads anyway. But, even more serious than that, Alpha was recently changed to ensure that it does not write over a newer version of the key (dgraph-io@a4bd06f2f). If commits come out of order, some of these commits can be dropped on the floor. This change fixes that by ensuring that Zero would send all the commits in the right order. P.S. Also did a change for @danielmai , which sets `stderrthreshold=0` always, and doesn't let a user overwrite it. Changelog: * Fix to ensure that Zero sends out all commit timestamps in order. * Do the sorting of txn status in Alpha, because Alpha also batches multiple updates from Zero.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zero had a race condition, where it could send commit timestamps out of order. This can cause invalid reads anyway. But, even more serious than that, Alpha was recently changed to ensure that it does not write over a newer version of the key (a4bd06f2f). If commits come out of order, some of these commits can be dropped on the floor.
This change fixes that by ensuring that Zero would send all the commits in the right order.
This change is