Task convertion from bool to int was done using uint32 #2621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A type conversion check was failing because it expected 8 byte value to convert to uint64, but the task conversion was returning 4 byte as uint32. This change fixes that conversion issue. Closes #2620
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
A type conversion check was failing because it expected 8 byte value to convert to uint64, but the task conversion was returning 4 byte as uint32. This change fixes that conversion issue. Closes dgraph-io#2620
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A type conversion check was failing because it expected 8 byte value
to convert to uint64, but the task conversion was returning 4 byte
as uint32. This change fixes that conversion issue.
Also fixed a couple of errors that had value but no format.
Closes #2620
This change is