add language aliases for broader support. #2602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reuse know language stopwords with similar languages. If/when the support for the languages is added the aliases are ignored. Ref: #2601
This was referenced Sep 29, 2018
added 4 commits
September 28, 2018 19:54
manishrjain
approved these changes
Oct 1, 2018
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
added 2 commits
October 1, 2018 16:45
…sue-2601_tokenizer_lang_error
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
* add language aliases for broader support. Reuse know language stopwords with similar languages. If/when the support for the languages is added the aliases are ignored. * added a test for all supported and potential fulltext index language tokenizers Ref: dgraph-io#2601
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuse known language stopwords with similar languages. If/when the
support for the languages is added the aliases are ignored.
This PR also changes language tokenizer errors to fatal so the client stops trying.
Ref: #2601
This change is