exit 1 when process schema file fails and it's not cancelled. #2596
Conversation
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @srfrog and @manishrjain)
dgraph/cmd/live/run.go, line 350 at r1 (raw file):
log.Println("Interrupted while processing schema file") } else { x.Checkf(err, "Error while processing schema file")
Schema file is one thing, but it could also fail trying to insert the RDF as the Github issue mentions. That still won't return a non-zero exit code.
srfrog
force-pushed
the
feature/isssue-2465_dgraph_live_import_fails_exit_0
branch
from
a2ea000
to
83584a7
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @srfrog)
dgraph/cmd/live/run.go, line 350 at r1 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
Schema file is one thing, but it could also fail trying to insert the RDF as the Github issue mentions. That still won't return a non-zero exit code.
this new change will allow the defers to close while exiting with code != 0
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @manishrjain)
dgraph/cmd/live/run.go, line 350 at r1 (raw file):
Previously, srfrog (Gus) wrote…
this new change will allow the defers to close while exiting with code != 0
Done.
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @manishrjain)
dgraph/cmd/live/run.go, line 382 at r3 (raw file):
if err := <-errCh; err != nil { log.Printf("Error while processing file %q: %s\n", err) return err
exit != 0 for RDF processing errors
…ssue-2465_dgraph_live_import_fails_exit_0
srfrog
deleted the
feature/isssue-2465_dgraph_live_import_fails_exit_0
branch
…-io#2596) * exit 1 when process schema file fails and it's not cancelled. * use exit != 0 for errors with processing RDF files. Closes dgraph-io#2465
Closes #2465
This change is