Remove LinRead map logic from Dgraph #2570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
We no longer need to keep track of Applied watermarks, to generate a lin read map; because transactions are now proposed and applied in order via Raft, in each group. For any given read ts, we can tell if the server has caught up to that ts, by the status of their individual Oracles, which are updated via proposals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer need to keep track of Applied watermarks, to generate a lin read map; because transactions are now proposed and applied in order via Raft, in each group. For any given read ts, we can tell if the server has caught up to that ts, by the status of their individual Oracles, which are updated via proposals.
This change is