Refactor and Optimize data streaming #2442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two kinds of data streaming going on. One is to do a predicate move on instructions from Zero. Other is when a replica server requests for a snapshot. Both were using different code, with very similar logic. So, refactored the two into one common file, stream_lists.go.
Also optimized the streaming, so we generate key ranges first, then have multiple goroutines pick up a range each, and iterate over it, generating one KVS per range. This output is then batched smartly and sent over the wire. This achieves pretty amazing transfer speeds (hard to say, because of the small data sets I'm playing with but, saw it spike to 20 Mbps before the data finishes).
Also fixed a whole bunch of bugs. Some in Badger related to key moves and nil txn.callbacks. And an assert failure in watermark.go.
This change is