-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JSON mutations to raw HTTP #2396
Conversation
Reviewed 3 of 3 files at r1. dgraph/cmd/server/http.go, line 173 at r1 (raw file):
JSON unmarshal needs to be worked upon. So, let's consolidate that in one place. Can you use the same method that grpc uses to unmarshal JSON; so it's all in one place? Comments from Reviewable |
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed. dgraph/cmd/server/http.go, line 173 at r1 (raw file): Previously, manishrjain (Manish R Jain) wrote…
This JSON marshal only validates the JSON and checks its I didn't change much because I wanted to introduce this change without affecting any other code. Comments from Reviewable |
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed. dgraph/cmd/server/http.go, line 172 at r1 (raw file):
map[string][]byte? So, you don't need to marshal below. Comments from Reviewable |
…case for number parsing
Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion. dgraph/cmd/server/http.go, line 172 at r1 (raw file): Previously, manishrjain (Manish R Jain) wrote…
Done. Comments from Reviewable |
Review status: all files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
This adds Json mutations to Dgraph's HTTP server.
Syntax:
Possible limitations/problems:
This change is