return error if keywords used as alias

Signed-off-by: பாலாஜி ஜின்னா <[email protected]>
dgraph-io · Jul 25, 2019 · 860dc04 · 860dc04
1 parent cf7c1e6
commit 860dc04
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/gql/parser.go b/gql/parser.go
@@ -1948,6 +1948,9 @@ func parseGroupby(it *lex.ItemIterator, gq *GraphQuery) error {
 				if alias != "" {
 					return item.Errorf("Expected predicate after %s:", alias)
 				}
+				if validKey(val) {
+					return item.Errorf("Can't use  %s as alias.", val)
+				}
 				alias = val
 				it.Next() // Consume the itemColon
 				continue

diff --git a/gql/parser_test.go b/gql/parser_test.go
@@ -3021,6 +3021,22 @@ func TestParseGroupbyWithAliasForKey(t *testing.T) {
 	require.Equal(t, "SchooL", res.Query[0].Children[0].GroupbyAttrs[1].Alias)
 }
 
+func TestParseGroupbyWithAliasForError(t *testing.T) {
+	query := `
+	query {
+		me(func: uid(0x1)) {
+			friends @groupby(first: 10, SchooL: school) {
+				count(uid)
+			}
+			hometown
+			age
+		}
+	}
+`
+	_, err := Parse(Request{Str: query})
+	require.Contains(t, err.Error(), "Can't use  first as alias.")
+}
+
 func TestParseGroupbyError(t *testing.T) {
 	// predicates not allowed inside groupby.
 	query := `