fix(manifest): fix manifest corruption due to race condition in concurrent compactions (#1756) #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@skrdgraph The CI jobs are not running because this needs to be merged into release/v3.2103 (not main)... Can we update the CI workflow to allow the jobs to run when a PR is opened against a release branch? See #1821 |
joshua-goldstein
force-pushed
the
joshua/update-release
branch
from
6a2b41a to
d949429
Compare
matthewmcneely
approved these changes
Oct 18, 2022
|
@skrdgraph It would be good to get the CI jobs to run against branch before merging, I have another open PR here that should get the jobs to run: #1821 |
joshua-goldstein
force-pushed
the
joshua/update-release
branch
from
81899eb to
dcfb65a
Compare
joshua-goldstein
requested review from
akon-dey,
gcxml and
billprovince
as code owners
…rrent compactions (#1756) `manifestFile.rewrite` closes the file due to which `manifest.fp.Sync()` can fail. This leads to an updated manifest but non-updated tables set. Hence, the compaction process enters into an infinite loop failing with the `MANIFEST removes non-existing table` error. This PR fixes it. (cherry picked from commit 6ed45ae)
joshua-goldstein
force-pushed
the
joshua/update-release
branch
from
dcfb65a to
29148c6
Compare
skrdgraph
approved these changes
Nov 3, 2022
mangalaman93
pushed a commit
that referenced
this pull request
Feb 14, 2023
…rrent compactions (#1756) (#1820) This PR is a cherry pick of #1756. Addresses [this issue](https://discuss.dgraph.io/t/badgerdb-manifest-corruption-issue-solution/15915) on Discuss and[ this issue](#1819) on Badger. Co-authored-by: Kenan Kessler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a cherry pick of #1756. Addresses this issue on Discuss and this issue on Badger.