Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When a prefix is dropped, the !badger!move prefixes associated with t… #1331

Merged
merged 5 commits into from
May 22, 2020
Merged

When a prefix is dropped, the !badger!move prefixes associated with t… #1331

merged 5 commits into from
May 22, 2020

Conversation

sana-jawad
Copy link
Contributor

@sana-jawad sana-jawad commented May 15, 2020 •
edited by manishrjain
Loading

…he prefix should also be removed.
Please refer #1288 for details

This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented May 15, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sana-jawad sana-jawad force-pushed the BadgerMoveKeysInDropPrefix branch from c8b59ab to 272b73d Compare May 15, 2020 21:24
jarifibrahim
jarifibrahim approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@jarifibrahim jarifibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: I'll get this approved by @manishrjain

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @ashish-goswami, @jarifibrahim, and @manishrjain)

jarifibrahim
jarifibrahim reviewed May 21, 2020
View reviewed changes
Copy link
Contributor

@jarifibrahim jarifibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Thank you for fixing this @sana-jawad 🎉

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @ashish-goswami, @jarifibrahim, and @manishrjain)

manishrjain
manishrjain approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Nice fix. Thanks, @sana-jawad .

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @ashish-goswami and @manishrjain)

@sana-jawad
Copy link
Contributor Author

sana-jawad commented May 21, 2020 •
edited by manishrjain
Loading

:lgtm: Thank you for fixing this @sana-jawad 🎉

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @ashish-goswami, @jarifibrahim, and @manishrjain)

Thanks for the review. Can you please help me merge this pull request. I am not seeing an option to merge.

@jarifibrahim
Copy link
Contributor

jarifibrahim commented May 22, 2020 •
edited
Loading

Hey @sana-jawad, I've made some minor changes to your code based on feedback. I removed the comment about move keys because 3e1cdd9 has fixed that.

I'll merge the PR once the build succeeds 🎉

@jarifibrahim jarifibrahim merged commit 1056675 into hypermodeinc:master May 22, 2020
@jarifibrahim
Copy link
Contributor

@sana-jawad I've merged your PR. Thank you for fixing this 🎉

@jarifibrahim jarifibrahim mentioned this pull request May 22, 2020
Closed
@damz damz mentioned this pull request Jun 21, 2020
Closed
NamanJain8 pushed a commit that referenced this pull request Sep 8, 2020
@sana-jawad @NamanJain8
Drop move keys when its key prefix is dropped (#1331)
7b92b62 
When a prefix `P` is dropped, we do not drop the `!badger!move!P` keys.
This PR fixes this issue by dropping `!badger!move!P` keys when keys
with prefix `P` are dropped via `dropPrefix()`.

(cherry picked from commit 1056675)
NamanJain8 added a commit that referenced this pull request Sep 9, 2020
@NamanJain8 @sana-jawad
Drop move keys when its key prefix is dropped (#1331) (#1503)
9ad4374 
When a prefix `P` is dropped, we do not drop the `!badger!move!P` keys.
This PR fixes this issue by dropping `!badger!move!P` keys when keys
with prefix `P` are dropped via `dropPrefix()`.

(cherry picked from commit 1056675)

Co-authored-by: sana-jawad <[email protected]>
jarifibrahim pushed a commit that referenced this pull request Oct 2, 2020
@sana-jawad
Drop move keys when its key prefix is dropped (#1331)
bd2fe1c 
When a prefix `P` is dropped, we do not drop the `!badger!move!P` keys.
This PR fixes this issue by dropping `!badger!move!P` keys when keys
with prefix `P` are dropped via `dropPrefix()`.
mYmNeo pushed a commit to mYmNeo/badger that referenced this pull request Jan 16, 2023
@NamanJain8 @sana-jawad @mYmNeo
Drop move keys when its key prefix is dropped (hypermodeinc#1331) (hy…
f91346e 
…permodeinc#1503)

When a prefix `P` is dropped, we do not drop the `!badger!move!P` keys.
This PR fixes this issue by dropping `!badger!move!P` keys when keys
with prefix `P` are dropped via `dropPrefix()`.

(cherry picked from commit 1056675)

Co-authored-by: sana-jawad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarifibrahim jarifibrahim jarifibrahim approved these changes

@manishrjain manishrjain manishrjain approved these changes

@ashish-goswami ashish-goswami Awaiting requested review from ashish-goswami

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sana-jawad @CLAassistant @jarifibrahim @manishrjain