DropPrefix: Return error on blocked writes #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 15, 2020 14:18
jarifibrahim
requested review from
ashish-goswami,
manishrjain and
a team
as code owners
martinmr
approved these changes
May 15, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ashish-goswami and @manishrjain)
added 4 commits
May 15, 2020 23:58
manishrjain
approved these changes
May 15, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status:
mYmNeo
added a commit
to mYmNeo/badger
that referenced
this pull request
Jan 17, 2023
Signed-off-by: thomassong <[email protected]>
mYmNeo
added a commit
to mYmNeo/badger
that referenced
this pull request
Feb 13, 2023
Signed-off-by: thomassong <[email protected]>
mYmNeo
added a commit
to mYmNeo/badger
that referenced
this pull request
Sep 14, 2024
Signed-off-by: thomassong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DropAll and DropPrefix both of them block writes before they start their processing. If both of them were called concurrently, one of them would panic because the other call would've blocked the writes. This PR fixes it by returning an error on blocked writes.
This change is