Fix TestGoroutineLeak and Example_subscribe test #1123
Conversation
Both the test use subscription and there was a race condition which would cause the builds to fail at times. This commit fixes it.
jarifibrahim
requested review from
ashish-goswami,
manishrjain and
a team
as code owners
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ashish-goswami, @jarifibrahim, and @manishrjain)
db_test.go, line 1595 at r1 (raw file):
}() // Wait for the go routine to be scheduled. time.Sleep(time.Second)
We changed to wait group for a certainity.
Is there any reason for changing from wait group from sleep
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ashish-goswami, @jarifibrahim, and @manishrjain)
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @balajijinnah and @manishrjain)
db_test.go, line 1595 at r1 (raw file):
Previously, balajijinnah (balaji) wrote…
We changed to wait group for a certainity.
Is there any reason for changing from wait group from sleep
The wait group doesn't ensure that the subscriber is ready. The tests would fail because the subscriber would not receive the update.
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @manishrjain)
Both the test use subscription API and there was a race condition that would cause the builds to fail at times. This commit fixes it. (cherry picked from commit ffb3450)
Both the test use subscription and there was a race condition which
would cause the builds to fail at times. This commit fixes it.
Fixes #1122 and #1087
This change is