Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

predict_proba reports unnormalised probabilities #40

Open
ablaom opened this issue Feb 19, 2019 · 2 comments
Open

predict_proba reports unnormalised probabilities #40

ablaom opened this issue Feb 19, 2019 · 2 comments

Comments

@ablaom
Copy link
Collaborator

ablaom commented Feb 19, 2019

The probabilities reported by this method (actually the log probabilities) are not normalised. Ie, if you exponentiate the reported probabilities and sum over all classes you do not get one.

It would be nice if this (somewhat unexpected) behaviour were documented somewhere, or if normalised probabilities were reported.

@dfdx
Copy link
Owner

dfdx commented Feb 20, 2019

Does it hold for all models or for some specific?

The right way would be to fix it and release a new version, but honestly I'm not sure I'll have time to dive into it anytime soon.

@ablaom
Copy link
Collaborator Author

ablaom commented Feb 20, 2019

The method is in common.jl, so it applies to all models. So you just need to fix that one method.

There is no urgency from our end. We are doing MLJ model implementations for NaiveBayes and, having noticed the problem, we have accounted for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants