Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safari 14 fix breaks fake-indexeddb (heads up) #1397

Closed
dusty-phillips opened this issue Sep 26, 2021 · 5 comments
Closed

Safari 14 fix breaks fake-indexeddb (heads up) #1397

dusty-phillips opened this issue Sep 26, 2021 · 5 comments

Comments

@dusty-phillips
Copy link
Contributor

I was testing some stuff with fakeindexeddb and found it crashed with the new 3.2.0 release candidate. The problem isn't in Dexie, but I'd recommend not releasing the 3.2.0 final until jakearchibald/safari-14-idb-fix#10 merges!
@dusty-phillips
Copy link
Contributor Author

Or possibly not: jakearchibald/safari-14-idb-fix#9 🤦

@dfahlander
Copy link
Collaborator

Thanks 🙏 I will need to update the devdep before building then

@dusty-phillips
Copy link
Contributor Author

Upstream doesn’t want to merge PR, so the navigator check will need to be moved up to dexie.

@dfahlander
Copy link
Collaborator

I released 3.2.0-rc.2 now with avoiding the fix if typeof navigator === 'undefined'. If you have a chance to test it, please let me know.

@dusty-phillips
Copy link
Contributor Author

Yep, working now. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dusty-phillips @dfahlander