perf: memory optimizations and prom metrics on terminal session exposed #4909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prakash100198
requested review from
vikramdevtron,
kripanshdevtron and
nishant-d
as code owners
github-actions
bot
added
PR:Issue-verification-failed
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
|
kripanshdevtron
approved these changes
Apr 12, 2024
komalreddy3
pushed a commit
that referenced
this pull request
May 28, 2024
…ed (#4909) * memory optimizations and prom metrics on terminal session exposed * inc terminal counter before stream actually starts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pr aims at several performance fixes related to GCing and channels and also exposing prometheus metrics for all terminal session activities.
Fixes #4883
Checklist:
Does this PR introduce a user-facing change?