Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI should be supported for pull requests #376

Closed
strawhat5 opened this issue Mar 15, 2021 · 2 comments
Closed

CI should be supported for pull requests #376

strawhat5 opened this issue Mar 15, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@strawhat5
Copy link
Contributor

Summary

Currently there are only 2 ways to configure CI on Git repo, using:

  1. Branch Name
  2. Tag regex

We would like to have a 3rd option to configure CI on pull requests raised on the Git repo.

Motivation

Bitbucket PR builder
Github PR builder

Proposal

We would like to propose a solution similar to Jenkins PR builder. Jenkins currently provides 2 options to build pull requests:

  1. PRs created on the source repo
  2. PRs created on forks (extra auth for private forks might be required)

Screenshot 2021-03-15 at 11 00 31 PM

And for each of the above 2 options, Jenkins provides 2 strategies to build the PRs:

  1. On the HEAD of source branch
  2. On the potential merge result on target branch

Screenshot 2021-03-15 at 10 59 32 PM

@strawhat5 strawhat5 added the enhancement New feature or request label Mar 15, 2021
@manish-agrawal-ai
Copy link
Contributor

Hello @strawhat5 ,
We have gone through your request and will be building this feature soon.
In the mean time, Can you cross validate your use case in the below sheet and answer some questions :

https://docs.google.com/document/d/1rHi888NqLd5_m-C7Di-__jt93Su0XWUMmrRc_C5JT_c/edit

@manish-agrawal-ai
Copy link
Contributor

This feature is available now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants