Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🍀 Proposal: Integrate the golangci-lint command in the makefile #632

Closed
imxw opened this issue May 30, 2022 · 3 comments
Closed

🍀 Proposal: Integrate the golangci-lint command in the makefile #632

imxw opened this issue May 30, 2022 · 3 comments
Assignees
@imxw @summingyu

Comments

@imxw
Copy link
Member

imxw commented May 30, 2022

What Would You Like to Add? Why is This Needed?

It is convenient for developers to detect problems when building locally. Improve the quality of integrating code

Design

  • make lint
  • Determine whether the golangci-lint is installed when building. If it is not installed, install it with go intall
@summingyu
Copy link
Contributor

Great, so is it also possible to check goimports or other installations?

@summingyu
Copy link
Contributor

Or you can call it a development environment check:)

@imxw
Copy link
Member Author

imxw commented May 30, 2022

Great, so is it also possible to check goimports or other installations?

Of course, will write a common function

@imxw imxw mentioned this issue May 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imxw imxw

@summingyu summingyu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@imxw @summingyu @daniel-hutao