Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: dtm verify shouldn't return any error before dtm apply #255

Closed
daniel-hutao opened this issue Mar 2, 2022 · 2 comments · Fixed by #260
Closed

Bug: dtm verify shouldn't return any error before dtm apply #255

daniel-hutao opened this issue Mar 2, 2022 · 2 comments · Fixed by #260
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@daniel-hutao
Copy link
Member

Describe the Bug

If the users forget to execute dtm apply after dtm init, but directly execute dtm verify, error log should not be output at this time.

See the https://github.com/merico-dev/stream/issues/252#issue-1156718149 for more info.

How to Reproduce

See the https://github.com/merico-dev/stream/issues/252#issue-1156718149 for more info.

@daniel-hutao daniel-hutao added bug Something isn't working good first issue Good for newcomers labels Mar 2, 2022
@daniel-hutao
Copy link
Member Author

/assign @IronCore864

@IronCore864
Copy link
Member

Thanks @imxw for submitting the issue!

This is a very good issue that emphasizes many points:

  1. dtm verify should not "fail" or "error" in any circumstances. The purpose of the "verify", as the word means, is to make sure if something is as expected.
  2. The "error" in the log is a bit too much. If an "error" message is displayed, the user might think something went wrong or something they did is wrong, which isn't the case in the original post's issue.

And this got us thinking: what exactly should verify do, and how will the users know the expected behavior of verify?

This leads to another point: we should have dedicated documentation explaining how everything works.

Thanks again for this great issue; a PR fixing it is on the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants