Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devspace dev --show-ui false expected to not start Devspace UI #2657

Closed
EdwinPhilip opened this issue Jun 15, 2023 · 5 comments
Closed

devspace dev --show-ui false expected to not start Devspace UI #2657

EdwinPhilip opened this issue Jun 15, 2023 · 5 comments
Assignees
Labels
bug kind/bug Something isn't working

Comments

@EdwinPhilip
Copy link

EdwinPhilip commented Jun 15, 2023

What happened?
We have another microservice that uses the Devspace UI default port 8090. I had to stop devspace dev and run yarn start in the other service. Then start devspace dev so that it takes different port

Currently i don't see a way to stop running devspace ui or change port number when started by devspace dev

What did you expect to happen instead?
I would like disable starting devspace ui by default

Possible solution:
devspace dev --show-ui false to not start devspace ui

@EdwinPhilip EdwinPhilip added the kind/bug Something isn't working label Jun 15, 2023
@lizardruss
Copy link
Collaborator

Can you try:

> devspace dev --show-ui=false

It doesn't look like --show-ui false works. According to this comment, I think it gets interpreted as --show-ui (true).

If you'd like to be able to specify a ui port instead that might require a code change. It looks like it was possible once upon a time.

@EdwinPhilip
Copy link
Author

EdwinPhilip commented Jun 19, 2023

By default, without --show-ui , devspace dev starts ui server and serves at localhost:8090
Not sure why we then have another flag here if the ui server starts by default.

I would like to contribute if this needs code change.
i see that code reference here

command.Flags().BoolVar(&cmd.ShowUI, "show-ui", cmd.ShowUI, "Shows the ui server")

Either would like to make --show-ui=false work or provide a way to change port number

can you help me if i am looking at the right place ?

@lizardruss
Copy link
Collaborator

devspace dev --show-ui=false

^ This already works for me to disabling the UI. If you'd like to submit a PR to add a --ui-port flag, that would be great. I believe the changes would be in the same file, and just a matter of adding the flag.

@EdwinPhilip
Copy link
Author

I just tried

devspace dev --show-ui=false

Didn't work for me. i can still access devspace ui at localhost:8090

DevSpace version : 6.3.2

@lizardruss
Copy link
Collaborator

Ah strange. I think this will need a deeper look. The flag seems to only affect whether a message is logged, and not whether the server is started or not. I don't have enough context to know the reasoning behind that. Adding the --ui-port flag may be the easier option since it seems this server is involved in dependency tracking too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants