Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adicionar workflow de PR #10

Open
huogerac opened this issue Oct 2, 2021 · 3 comments
Open

Adicionar workflow de PR #10

huogerac opened this issue Oct 2, 2021 · 3 comments
Labels
Devops help wanted Extra attention is needed

Comments

@huogerac
Copy link
Contributor

huogerac commented Oct 2, 2021

Configurar GH para quando tem um PR, ele fica aguardando outra pessoa revisar o código antes de ficar verde para merge!
@huogerac huogerac added the help wanted Extra attention is needed label Oct 2, 2021
@huogerac huogerac added the Devops label Oct 3, 2021
@wfoschiera
Copy link

@huogerac, veja se é essa a alteração desejada: Regras de proteção de branches
Não tenho permissão para acessar o settings do repositório

@huogerac
Copy link
Contributor Author

Legal @wfoschiera !

Acredito que exatamente isto que precisamos configurar!

  • não permitir push para master diretamente
  • aceitar PR com pelo menos 1 revisão antes de fazer merge

Obrigado

@huogerac
Copy link
Contributor Author

Valeu @wfoschiera
Configurei o settings e acredito que agora temos:

  • branch main protegida (nao podemos fazer commit direto na main)
  • PR fica aguardado pelo menos 1 review para aceitar merge
  • precisa passar no linter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Devops help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@huogerac @wfoschiera