Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for "targetTag" variable of Docker Build promotion API #370

Closed
rybrow opened this issue Aug 30, 2022 · 1 comment · Fixed by #373
Closed

Add support for "targetTag" variable of Docker Build promotion API #370

rybrow opened this issue Aug 30, 2022 · 1 comment · Fixed by #373
Labels
good first issue Help Wanted We will be glad if somebody proposes a solution via PR

Comments

@rybrow
Copy link

rybrow commented Aug 30, 2022

Looking at the docs and the source code for the promote_docker_image method, it doesnt look like the "targetTag" variable is supported as per https://www.jfrog.com/confluence/display/JFROG/Artifactory+REST+API#ArtifactoryRESTAPI-PromoteDockerImage

We should be able to specify target tags similar to the JFROG API via this library , for example

path.promote_docker_image("docker-local", "docker-release-candidate", "my-application", "0.5.1", target_tag="0.5.1-RC1")
@beliaev-maksim
Copy link
Member

I think this was added only in the latest version of API

@allburov allburov added good first issue Help Wanted We will be glad if somebody proposes a solution via PR labels Sep 4, 2022
@donhui donhui mentioned this issue Sep 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Help Wanted We will be glad if somebody proposes a solution via PR
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add params for promote_docker_image() donhui/artifactory
3 participants
@allburov @beliaev-maksim @rybrow