Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#877: improved process error message #895

Merged
merged 2 commits into from
Dec 12, 2024
Merged

#877: improved process error message #895

merged 2 commits into from
Dec 12, 2024

Conversation

jan-vcapgemini
Copy link
Contributor

Fixes: #877

Implements:

  • added static getLogLevelFromErrorHandling method to IdeLogLevel
  • removed Internal error message
  • replaced check of ProcessErrorHandling with getLogLevelFromErrorHandling

@jan-vcapgemini
devonfw#877: improved process error message
1c20a31 
added static getLogLevelFromErrorHandling method to IdeLogLevel
removed Internal error message
replaced check of ProcessErrorHandling with getLogLevelFromErrorHandling
@jan-vcapgemini jan-vcapgemini self-assigned this Dec 12, 2024
@coveralls
Copy link
Collaborator

coveralls commented Dec 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12297130395

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 13 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 67.091%
Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/log/IdeLogger.java 2 63.04%
com/devonfw/tools/ide/process/ProcessContextImpl.java 11 79.24%
Totals Coverage Status
Change from base Build 12293756306: -0.02%
Covered Lines: 6622
Relevant Lines: 9525
💛 - Coveralls

@jan-vcapgemini
devonfw#877: implemented requested changes
38a60bc 
replaced getLogLevelFromErrorHandling with getLogLevel
@hohwille hohwille added this to the release:2024.12.001 milestone Dec 12, 2024
hohwille
hohwille approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jan-vcapgemini thanks for the update. Perfect now 👍
Ready for merge.

@hohwille hohwille merged commit 68713f1 into devonfw:main Dec 12, 2024
4 checks passed
@hohwille hohwille mentioned this pull request Dec 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hohwille hohwille hohwille approved these changes

Assignees

@jan-vcapgemini jan-vcapgemini

Labels
None yet
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2024.12.001
Development

Successfully merging this pull request may close these issues.

mvn on Mac x64 throws an Exception
3 participants
@jan-vcapgemini @coveralls @hohwille