Add code coverage GitHub Action #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #943 +/- ##
=======================================
Coverage ? 48.50%
=======================================
Files ? 36
Lines ? 2307
Branches ? 0
=======================================
Hits ? 1119
Misses ? 1076
Partials ? 112 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
amisevsk
approved these changes
Oct 5, 2022
codecov.yml
Outdated
| @@ -0,0 +1,2 @@ | |||
| github_checks: | |||
| annotations: false | |||
Fix devfile#929 Signed-off-by: Andrew Obuchowicz <[email protected]>
AObuchow
force-pushed
the
add_code_coverage_action_final
branch
from
e71caf6 to
c08e67c
Compare
ibuziuk
approved these changes
Oct 11, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk, AObuchow, ibuziuk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enables the creation of code coverage reports for the repository.
A new CI action will run for PR's and for pushes to the main branch. The latter is required to have coverage reports which PR coverage reports can be compared against.
I've disabled the annotations which point out which lines of code are not tested, as I personally find them to make PR's harder to read.
I also added the codecov badge to the README.
One thing to note: the codecov GH app must be enabled. I sent a request for this yesterday and saw today that it seems to be enabled. So there shouldn't be any issue there.
What issues does this PR fix or reference?
#929
Is it tested? How?
Testing is a bit tricky as this GH actions can only really be tested after they are merged.Edit: Apparently, the code coverage action is running in this PR.. though it is likely to not work correctly as the main branch does not have a code coverage report uploaded to codecov.io yet.
I did test out the action on my own fork of the repo, and it seems to be working as expected.
I did not however test that the badge is working as expected, this will have to be verified after this PR is merged.
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che