Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add restrictions for automount volumes when restricted-access annotation is used #1225

Open
amisevsk opened this issue Jan 29, 2024 · 0 comments

Comments

@amisevsk
Copy link
Collaborator

Description

We should add a restriction to automount volumes when the controller.devfile.io/restricted-access annotation is used with a DevWorkspace. To do this, we would likely need to extend restricted-access functionality to configmaps and secrets:

  1. If an automount configmap/secret has controller.devfile.io/restricted-access annotation,
    1. Label it a creator ID like we do for workspaces
    2. Disallow any modifications except for by the creator (and optionally DevWorkspace SA if needed)
  2. If a DevWorkspace has the controller.devfile.io/restricted-access annotation, only auto-mount configmaps/secrets/pvcs that have the controller.devfile.io/restricted-access annotation as well

For workspaces that do not use controller.devfile.io/restricted-access, nothing changes and automount resources work as they currently do (all automount resources in the namespace are mounted).

Additional context

This would be useful as an added safeguard to ensure restricted-access workspaces don't import any data that isn't controlled entirely by the creator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant