Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry operator next image push CI silently failing #1328

Closed
michael-valdron opened this issue Nov 3, 2023 · 1 comment · Fixed by devfile/registry-operator#57
Closed
Assignees
Labels
area/registry Devfile registry for stacks and infrastructure kind/bug Something isn't working

Comments

@michael-valdron
Copy link
Member

Which area this feature is related to?

/kind bug

Which area this bug is related to?

/area registry

What versions of software are you using?

Go project

Operating System and version: N/A

Go Pkg Version: 1.19

Bug Summary

Describe the bug:

GitHub workflow 'Next Dockerimage' runs are silently failing due to an update to docker/build-push-action in devfile/registry-operator#56 to v5.0.0. Any version after v2 uses docker buildx and requires a different setup.

To Reproduce:

Enable actions under folk and try a pushing a commit to the main branch. Workflow should quickly fail before an image is built, under devfile/registry-operator repo runs the image still builds even after failing with the same error.

Expected behavior

Workflow should succeed if secrets are correct. If secrets are unset or incorrect, workflow should still build the image then fail on push with the unauthorized error.

Any logs, error output, screenshots etc? Provide the devfile that sees this bug, if applicable

Latest run: https://github.com/devfile/registry-operator/actions/runs/6709501591

Additional context

Any workaround?

N/A

Suggestion on how to fix the bug

Revert docker/build-push-action to use v1.1.x versions.

@michael-valdron michael-valdron self-assigned this Nov 3, 2023
@openshift-ci openshift-ci bot added kind/bug Something isn't working area/registry Devfile registry for stacks and infrastructure labels Nov 3, 2023
@michael-valdron michael-valdron moved this to In Progress 🚧 in Devfile Project Nov 3, 2023
@michael-valdron michael-valdron moved this from In Progress 🚧 to In Review 👀 in Devfile Project Nov 3, 2023
@michael-valdron
Copy link
Member Author

PR ready for review: devfile/registry-operator#57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/registry Devfile registry for stacks and infrastructure kind/bug Something isn't working
Projects
Status: Done ✅
Development

Successfully merging a pull request may close this issue.

1 participant