-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Difference highlighting styles missing #1114
Labels
Comments
3 tasks
Diff change highlighting styles have been added and approved, just waiting on additional reviews for tied issue: #1057 (comment) |
Blocked for the same reason as #1113 (comment). |
This was referenced May 9, 2023
No longer being blocked by #1057 and is now open for review in PR devfile/devfile-web#88. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Which area this feature is related to?
/kind bug
Which area this bug is related to?
/area landing-page
What versions of software are you using?
Node.js project
Operating System and version: N/A
Node.js version: 16
Yarn version: 1.22.18
Project.json: 15.2.1
Bug Summary
Describe the bug:
When using a markdown diff fence to showcase changes in source the highlighting of the changes is missing. This is due to the site css missing styling for these kinds of elements.
To Reproduce:
yarn nx serve landing-page
http://localhost:4200/docs/<version>/<filename-without-ext>
Expected behavior
Should show appropriate highlighting on changes, deleted line changes should be some form of red, and inserted line changes should be some form of green.
Any logs, error output, screenshots etc? Provide the devfile that sees this bug, if applicable
Additional context
Any workaround?
None.
Suggestion on how to fix the bug
Add styling blocks to site css which creates what is expected for changed lines under diff fences.
Target Date: 05-16-2023
The text was updated successfully, but these errors were encountered: