Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference highlighting styles missing #1114

Closed
michael-valdron opened this issue May 3, 2023 · 4 comments · Fixed by devfile/devfile-web#88
Closed

Difference highlighting styles missing #1114

michael-valdron opened this issue May 3, 2023 · 4 comments · Fixed by devfile/devfile-web#88
Assignees
Labels
area/landing-page Issues with the Landing Page kind/bug Something isn't working

Comments

@michael-valdron
Copy link
Member

michael-valdron commented May 3, 2023

Which area this feature is related to?

/kind bug

Which area this bug is related to?

/area landing-page

What versions of software are you using?

Node.js project

Operating System and version: N/A

Node.js version: 16

Yarn version: 1.22.18

Project.json: 15.2.1

Bug Summary

Describe the bug:

When using a markdown diff fence to showcase changes in source the highlighting of the changes is missing. This is due to the site css missing styling for these kinds of elements.

To Reproduce:

  1. Checkout what is the latest commit at the time of writing this
  2. Create a new markdown doc page file and place a diff fence in that file with source changes
  3. Run a local server of the landing page, yarn nx serve landing-page
  4. Visit this doc page under http://localhost:4200/docs/<version>/<filename-without-ext>
  5. Rendered diff fence will not have highlighting for changed lines

Expected behavior

Should show appropriate highlighting on changes, deleted line changes should be some form of red, and inserted line changes should be some form of green.

Any logs, error output, screenshots etc? Provide the devfile that sees this bug, if applicable

Screenshot from 2023-05-03 16-00-27

Additional context

Any workaround?

None.

Suggestion on how to fix the bug

Add styling blocks to site css which creates what is expected for changed lines under diff fences.

Target Date: 05-16-2023

@michael-valdron michael-valdron self-assigned this May 3, 2023
@openshift-ci openshift-ci bot added kind/bug Something isn't working area/landing-page Issues with the Landing Page labels May 3, 2023
@michael-valdron michael-valdron moved this to In Review 👀 in Devfile Project May 3, 2023
@michael-valdron
Copy link
Member Author

Diff change highlighting styles have been added and approved, just waiting on additional reviews for tied issue: #1057 (comment)

@michael-valdron
Copy link
Member Author

#1057 (comment)

@michael-valdron
Copy link
Member Author

Blocked for the same reason as #1113 (comment).

@michael-valdron
Copy link
Member Author

No longer being blocked by #1057 and is now open for review in PR devfile/devfile-web#88.

@elsony elsony changed the title Diff fence highlighting styles missing Difference highlighting styles missing May 9, 2023
@yangcao77 yangcao77 moved this from In Review 👀 to Done ✅ in Devfile Project May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/landing-page Issues with the Landing Page kind/bug Something isn't working
Projects
Status: Done ✅
Development

Successfully merging a pull request may close this issue.

1 participant