You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Validate stacks github action for the registry repo will trigger on every open PR. It will find the change delta and only run the test suite against changed stacks.
However, if the stack contains multiple versions (ie. has a stack.yaml in the stack root) and the directory's version name has been changed, the delta will not be correctly picked up.
The delta is created with get_stacks.sh and will use a git diff to find the files changed. In the case where an existing version directory name is changed, the diff will look like this:
Yeah it looks like the stack did get picked up stackDirs=udi (which was the main issue with multi version stacks) but then it still says 0 tests were ran so it might be another problem in the tests.
mike-hoang
changed the title
delta testing multi version stacks don't work correctly
Changes to registry stacks directory version names don't get picked up in delta test
Apr 13, 2023
Which area this feature is related to?
/kind bug
Which area this bug is related to?
/area registry
Bug Summary
Describe the bug:
The
Validate stacks
github action for the registry repo will trigger on every open PR. It will find the change delta and only run the test suite against changed stacks.However, if the stack contains multiple versions (ie. has a
stack.yaml
in the stack root) and the directory's version name has been changed, the delta will not be correctly picked up.The delta is created with
get_stacks.sh
and will use a git diff to find the files changed. In the case where an existing version directory name is changed, the diff will look like this:and the existing regex (
stacks\/(.*)\/devfile\.yaml
) won't match correctly.To Reproduce:
Change a version directory in an existing multi version stack and open a PR to trigger the test.
Expected behavior
The changed version stack should be picked up in the
get_stacks.sh
Additional context
Any workaround?
Force
TEST_DELTA
to be false to turn off delta testing.Suggestion on how to fix the bug
Update the way
changed_stacks
are found inget_stacks.sh
The text was updated successfully, but these errors were encountered: