-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fp-ts@2 support added #34
Conversation
export interface RemoteDataT<F> extends ApplicativeComposition<F, URI> { | ||
export interface RemoteDataT<M, E, A> extends HKT<M, RemoteData<E, A>> {} | ||
|
||
export interface RemoteDataM<F> extends ApplicativeCompositionHKT2<F, URI> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YBogomolov Could you help with reviewing the transformer module please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I like how the code style is streamlined with fp-ts@2 style 👍🏻
@mlegenhausen Thanks for you work! However we can't merge this to master because of direct repo reference in /cc @sutarmin |
export interface RemoteDataT<F> extends ApplicativeComposition<F, URI> { | ||
export interface RemoteDataT<M, E, A> extends HKT<M, RemoteData<E, A>> {} | ||
|
||
export interface RemoteDataM<F> extends ApplicativeCompositionHKT2<F, URI> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I like how the code style is streamlined with fp-ts@2 style 👍🏻
Before we merge I would like to add the |
I reworked the code to add |
@mlegenhausen Thanks for you work! @sutarmin I'd like to discuss if we're ready to go classless. Migration to |
I don't see any reasons for separating But regarding this PR, we can either rewrite to classless approach here or merge this one (once |
So, summing up, we're still waiting for |
@raveclassic, just FYI – |
Nice! Now I think we could update this PR, merge it and then work on making RD classless is separate PR, to be more granular. |
Agree on moving classless to separate PR |
I updated the pull request. Would be ok from my side. Could we then already start with a |
* fp-ts@2 support added * Code cleanups * Comment 2v suffix removed * pipeable operators added BREAKING CHANGE: fp-ts and io-ts-types dependencies updated to latest stable version
I added the minimum changeset to get the library working with
fp-ts@2
. I was not able to make it backwards compatible cause of the removal ofMonodial
, the changes in theFoldable
andAlternative
instances.Would be great if you could take a first look and give me feedback.
I add a
fp-ts-v2-lib
branch so you can try it out directly