RemoteDataT transformer #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raveclassic
suggested changes
Jan 29, 2019
raveclassic
approved these changes
Jan 31, 2019
|
Looks like I'm fine with the changes. @sutarmin please take a look. |
|
@gcanti, would you be so kind to help us with reviewing the transformer? |
|
@raveclassic LGTM |
|
@gcanti Thanks! |
|
@YBogomolov Thanks for collaboration! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of a
RemoteDataTmonadic transformer, as per reference implementations likeEitherT,OptionTand so on.Tests contain only logic for
chainmethod, and this should be sufficient, as can be seen in test for EitherT in fp-ts.