Skip to content

Commit

Permalink
Merge pull request #156 from developmentseed/patch/limit-fastapi-version
Browse files Browse the repository at this point in the history
limit fastapi upper version to avoid starlette breaking change
  • Loading branch information
vincentsarago authored Jan 8, 2024
2 parents 4426af7 + efb2695 commit 1713947
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ Note: Minor version `0.X.0` update might break the API, It's recommended to pin

- add `tags` to all routes
- fix `collections` and `items` HTML templates to keep query-parameters when changing the `page size`
- update FastAPI version upper limit to `<0.107.0` to avoid starlette breaking change (0.28)

## [0.5.6] - 2023-12-19

Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ dependencies = [
"orjson",
"asyncpg>=0.23.0",
"buildpg>=0.3",
"fastapi>=0.100.0",
"fastapi>=0.100.0,<0.107.0",
"jinja2>=2.11.2,<4.0.0",
"morecantile>=5.0,<6.0",
"pydantic>=2.4,<3.0",
Expand Down

1 comment on commit 1713947

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'TiPg Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.

Benchmark suite Current: 1713947 Previous: 4426af7 Ratio
tests/benchmarks.py::test_benchmark_items[html-200] 24.712954293178914 iter/sec (stddev: 0.027734393537846666) 32.28990901669839 iter/sec (stddev: 0.015045477862115228) 1.31
tests/benchmarks.py::test_benchmark_item[geojson-Saskatchewan] 43.92404885140489 iter/sec (stddev: 0.0257438825846512) 59.97789229095474 iter/sec (stddev: 0.015488309688408924) 1.37

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.