Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team Detail: Make table searchable and sortable #319

Open
batpad opened this issue Nov 22, 2022 · 5 comments
Open

Team Detail: Make table searchable and sortable #319

batpad opened this issue Nov 22, 2022 · 5 comments
Assignees

Comments

@batpad
Copy link
Member

batpad commented Nov 22, 2022

@LanesGood - there is a desire to make the table on the team detail page "searchable and sortable". Could you help outline here what that might involve UX wise and we can discuss how this fits / how best to proceed.

cc @jenningsanderson @kamicut @vgeorge

@batpad
Copy link
Member Author

batpad commented Nov 29, 2022

@jenningsanderson is this around making the list of users searchable? On the org page or the team page or both?

@LanesGood
Copy link
Member

@vgeorge to start looking into adding react-table as a solution for search, sort, filtering, etc.

@batpad
Copy link
Member Author

batpad commented Dec 13, 2022

Based on discussion:

  • We will add pagination and search for the organization teams table as well as the tables with user lists.

For users, we will try and use the display_name key in the profile, which should be populated with the user's OSM username.

This relates to #298

@vgeorge @kamicut can you add any notes about handling the OSM usernames in the database, any concerns, etc. - at this point, let us not worry about the case where a user changes their name in OSM. Hopefully this approach of storing the OSM usernames in the database can help with search, as well as reduce the need / dependency on OSM for the id -> username lookup.

@batpad
Copy link
Member Author

batpad commented Dec 14, 2022

Speaking to @kamicut, this is a bit more complex since we currently don't store display_names for users that are not signed up for OSM Teams (i.e. users can exist just as ids that are part of teams).

@kamicut - would you be able to outline your solution / how you're thinking about this a bit here?

@vgeorge
Copy link
Member

vgeorge commented Dec 23, 2022

Status update: we added pagination of staff and members to organizations pages and cache for username fetching from OpenStreetMap.

My suggested next steps for completing this ticket are:

  • Add pagination at the team page (route team/:id) (we need to implement paginate param to /api/teams/:id route are suggested here
  • Add perPage parameter to all paginated routes
  • Implement search param in staff/members API routes
  • Add search input to staff/member tables on the org page
  • Add search input to staff/member tables on the team page
  • Implement sort param in staff/members API routes
  • Add sort by name component to staff/member tables on the org page
  • Add sort by name component to staff/member tables on the team page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants