implemented replacement of localstack with localhost to load localstack images in browser
#165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lstack images in browser
danielfdsilva
approved these changes
Dec 9, 2020
danielfdsilva
requested changes
Dec 9, 2020
Co-authored-by: Daniel da Silva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I'm changing:
I added a check to see if the app is running in a dev environment and if so replace
localstackwithlocalhostin all imagesrcurls.See this comment detailing why this is necessary
How I did it:
process.node.NODE_ENVfordevelopmentsrcurlHow you can test it:
nasa-aptand rundocker-compose up --build)nvm install && yarn install && yarn startVerify the
test-atbd-1loads an image of the full moon (in the webpage) and that the image is also present in the generated pdf.