-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Google Cloud Storage backend #179
Add Google Cloud Storage backend #179
Conversation
👏👏👏👏 this is awesome @AndreaGiardini, I'm not a GoogleCloud storage so I'm not sure how to really test this It might be interesting to other if we could add some notes about the cloud (aws and google) backends somewhere here https://github.com/developmentseed/cogeo-mosaic/blob/master/docs/advanced/backends.md (like link how to create session or account 🤷♂️ ) |
@vincentsarago I added some documentation and tests. I tried the change myself using the CLI, both uploading and downloading files. Seems to work fine for me. Would be cool though to have somebody else test it as well. Let me know if something else is missing |
Hey @vincentsarago sorry for pinging again. do you have any updates about this? Can we run the CI? |
sorry @AndreaGiardini
🙏 |
87c1a0b
to
036b62a
Compare
@vincentsarago all pre-commit hooks are passing now |
thanks @AndreaGiardini |
That's great @vincentsarago Looking forward to seeing this landing on titiler so that we can read mosaic from GCS! |
cogeo-mosaic requirement for TiTiler is https://github.com/developmentseed/titiler/blob/master/src/titiler/mosaic/setup.py#L10 so you should be all set now |
Hello 👋
I took some time to implement a backend driver for Google Cloud Storage. I've followed the S3 implementation and changed what was needed.
I didn't add any tests yet. Let me know if you have some initial feedback about it.