Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google Cloud Storage backend #179

Merged
merged 3 commits into from
Jul 8, 2021

Conversation

AndreaGiardini
Copy link
Contributor

Hello 👋

I took some time to implement a backend driver for Google Cloud Storage. I've followed the S3 implementation and changed what was needed.

I didn't add any tests yet. Let me know if you have some initial feedback about it.

@vincentsarago
Copy link
Member

👏👏👏👏 this is awesome @AndreaGiardini, I'm not a GoogleCloud storage so I'm not sure how to really test this

It might be interesting to other if we could add some notes about the cloud (aws and google) backends somewhere here https://github.com/developmentseed/cogeo-mosaic/blob/master/docs/advanced/backends.md (like link how to create session or account 🤷‍♂️ )

@AndreaGiardini
Copy link
Contributor Author

@vincentsarago I added some documentation and tests.

I tried the change myself using the CLI, both uploading and downloading files. Seems to work fine for me.
I've used titiler with this custom version of cogeo-mosaic and indeed I can read private mosaic files (before we had to use public HTTP endpoints).

Would be cool though to have somebody else test it as well.

Let me know if something else is missing

@AndreaGiardini
Copy link
Contributor Author

Hey @vincentsarago sorry for pinging again. do you have any updates about this? Can we run the CI?

@vincentsarago
Copy link
Member

sorry @AndreaGiardini
Could you please run pre-commit to fix listing issues

pip install -e .["dev"]
pre-commit install
pre-commit run --all-files

🙏

@AndreaGiardini
Copy link
Contributor Author

@vincentsarago all pre-commit hooks are passing now

@vincentsarago vincentsarago merged commit 8e409b4 into developmentseed:master Jul 8, 2021
@AndreaGiardini AndreaGiardini deleted the gcs_backend branch July 8, 2021 09:48
@vincentsarago
Copy link
Member

thanks @AndreaGiardini
I just pushed a release https://github.com/developmentseed/cogeo-mosaic/blob/master/CHANGES.md#302-2021-07-08
it should be on pypi soon

@AndreaGiardini
Copy link
Contributor Author

That's great @vincentsarago

Looking forward to seeing this landing on titiler so that we can read mosaic from GCS!

@vincentsarago
Copy link
Member

cogeo-mosaic requirement for TiTiler is https://github.com/developmentseed/titiler/blob/master/src/titiler/mosaic/setup.py#L10 so you should be all set now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants