Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename http.py -> web.py #133

Merged
merged 2 commits into from
Oct 22, 2020
Merged

Rename http.py -> web.py #133

merged 2 commits into from
Oct 22, 2020

Conversation

kylebarron
Copy link
Member

@kylebarron kylebarron commented Oct 22, 2020 •
edited
Loading

It's probably good to rename http.py to another file name because a Python stdlib module is named http. So for example I can't even start a Jupyter kernel/session in that directory, because the local http.py hides the stdlib import.

Completely open to suggestions of how to rename http.py 🤷‍♂️

@vincentsarago
Copy link
Member

I think web is fine, thanks @kylebarron

@vincentsarago vincentsarago merged commit 039d9a3 into developmentseed:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylebarron @vincentsarago