Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for nested mosaics #122

Closed
kylebarron opened this issue Oct 15, 2020 · 0 comments · Fixed by #131
Closed

Remove support for nested mosaics #122

kylebarron opened this issue Oct 15, 2020 · 0 comments · Fixed by #131

Comments

@kylebarron
Copy link
Member

kylebarron commented Oct 15, 2020

In places like

# check if we have a mosaic in the url (.json/.gz)
return list(
itertools.chain.from_iterable(
[
get_assets_from_json(tiles, quadkey_zoom, x, y, z)
if os.path.splitext(asset)[1] in [".json", ".gz"]
else [asset]
for asset in assets
]
)
)

and

assets = list(
itertools.chain.from_iterable(
[self._fetch_dynamodb(qk).get("assets", []) for qk in quadkeys]
)
)

there's inherited old code that supports nested mosaics, where I think an asset of a mosaic can reference another mosaic?

Since this isn't documented anywhere, I think we should remove it, unless you're still using this internally? I think it would make the code a lot clearer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant