Fix ingestor regressions introduced by developmentseed/cdk-pgstac/pull/18. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emileten
added a commit
that referenced
this pull request
Apr 6, 2023
emileten
added a commit
that referenced
this pull request
Apr 6, 2023
3 tasks
emileten
added a commit
that referenced
this pull request
Apr 14, 2023
* bump default pypgstac version in bootstrapper * fix regression introduced by #19 * convert StacCollection object to list of Dict to comply with pypgstac expectations * format * add unit test that verifies the call to pypgstac.load.Loader.load_collections to avoid future regressions * format * clean up conftest StacCollection generator, make use of it in new test * remove unused import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The migration of collection creation code from
veda-stac-ingestorintroduced several regressions and revealed some code fixes that were not migrated in previous PRs.