-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
babel-transform-jsx: handle JSX fragments #85
Conversation
Isn't the default behaviour what folks want here? // input:
<Fragment>
<div />
<div />
</Fragment>
// output:
html`
<${Fragment>
<div />
<div />
</${Fragment}>
` |
No. |
@blikblum seems reasonable. I'll need a bit to properly review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the idea is sound 👍 Added a couple of suggestions regarding the structure and formatting, and added a suggestion to use this opportunity to make the plugin more robust overall.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Great job, @blikblum 👍
Thanks! |
Makes jsx to htm babel transform handle JSX fragments both React.Fragment and short (<></>) syntax.
Basically removes the fragment nodes