Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single line comments break props parsing #213

Open
marvinhagemeister opened this issue Aug 31, 2021 · 0 comments · May be fixed by #214
Open

Single line comments break props parsing #213

marvinhagemeister opened this issue Aug 31, 2021 · 0 comments · May be fixed by #214

Comments

@marvinhagemeister
Copy link
Collaborator

marvinhagemeister commented Aug 31, 2021

Single line comments in the opening tag seem to break props parsing. The rendered vnode will only receive an empty object as props.

html`<span
    // Every attribute after this comment will be dropped
    id="foo"
  />`

Actual Behavior

// returned vnode
{
  props: {},
}

Expected Behavior

// returned vnode
{
  props: { id: "foo" },
}
@marvinhagemeister marvinhagemeister linked a pull request Sep 1, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant