Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for more prebuild systems #78

Open
Julusian opened this issue Apr 15, 2022 · 2 comments
Open

Support for more prebuild systems #78

Julusian opened this issue Apr 15, 2022 · 2 comments
Labels

Comments

@Julusian
Copy link
Contributor

This application is doing a lot of work to invoke prebuild-install correctly, but does not for any other prebuild system. It falls back to relying on either npm rebuild or invoking yarn run install for dependencies.

However, when cross-compiling (eg for arm mac from intel), it is not setting npm_config_platform or npm_config_arch, so the yarn run install gets run for the host architecture rather than the target architecture. Or the other related variables.
It feels like those variables should be defined when invoking either npm rebuild or yarn run install.

I am also wondering why does prebuild-install need such special treatment? It listens to those same variables, so it feels like it should be possible to let it use the same code flow. A good example of why is https://github.com/lovell/sharp, because it does a pre-step of downloading the correct libvips dll/so files, before invoking prebuild-install. Which means that this application is only doing half of the rebuild for that library

Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Mar 15, 2024
@damms005
Copy link

damms005 commented Apr 2, 2024

I think this is a genuine issue that should not be bot-closed.

@lovell captures this well, especially with his suggested solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants