You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Interestingly the old icon shows correctly in Finder whereas the new icon shows a generic image icon, so possibly the file format is invalid somehow (though using an online icns->png converter works):
The text was updated successfully, but these errors were encountered:
I rebuilt the icon using iconutil and it both looks correct in Finder and fixes the build. I will leave this open since I think it might be worth panicking with a better error when len(result) == 0, but feel free to close at your convenience!
I found what may be the same crash reported in electron-userland/electron-builder#5844
I recently changed my app's macos icon (the build works and the icon displays correctly), and now when I build for linux, the build crashes here:
app-builder/pkg/icons/icns-to-png.go
Line 60 in b44c187
The error message is
panic: runtime error: index out of range [-1]
, meaning thisresult
slice is empty.Here's the old icon: https://s3.amazonaws.com/community.amazingmarvin.com/old_icon.icns
and the new icon: https://s3.amazonaws.com/community.amazingmarvin.com/new_icon.icns
Interestingly the old icon shows correctly in Finder whereas the new icon shows a generic image icon, so possibly the file format is invalid somehow (though using an online icns->png converter works):

The text was updated successfully, but these errors were encountered: