Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add an option to force using prebuilt binaries #49

Open
ccheraa opened this issue Feb 17, 2021 · 0 comments
Open

[Feature Request]: Add an option to force using prebuilt binaries #49

ccheraa opened this issue Feb 17, 2021 · 0 comments

Comments

@ccheraa
Copy link

ccheraa commented Feb 17, 2021

I don't know GO lang but I tried to read the code, and from what I understood is that the value of hasPrebuildInstall will be true if there is a prebuild-install dependency in package.json:

for name := range info.Dependencies {
if name == "prebuild-install" {
jsonWriter.WriteMore()
jsonWriter.WriteObjectField("hasPrebuildInstall")
jsonWriter.WriteBool(true)
break
}
}

Then if the value hasPrebuildInstall is not true, the function installUsingPrebuild will not try to download the prebuilt binary.

if !dependency.HasPrebuildInstall {
return nil, nil
}

It would be nice if there was an option to somehow pass an array of modules to installUsingPrebuild and the function will try to use their prebuilt binaries regardless of the value of hasPrebuildInstall (regardless of whether they use prebuild-install or no)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant