Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade deps, add storybook #96

Open
dev-shah7 opened this issue Feb 9, 2025 · 0 comments
Open

Upgrade deps, add storybook #96

dev-shah7 opened this issue Feb 9, 2025 · 0 comments
Labels

Comments

@dev-shah7
Copy link

Changes

Adds phoenix storybook dependency along with example pages for dropdowns and basic inputs. In order to make it work I had to upgrade some deps:

  • phoenix_ecto to 4.5
  • phoenix_html to 4.1
  • phoenix_live_view to 1.0

There were some breaking changes which I'll take notes on in self-review

There are a couple known issues with storybook installation:

  1. The storybook area (./storybook) uses its own JS bundle which is using pre-1.0 version of liveview. This causes a console warning but no real-world issues as far as I can tell. A new version of storybook should be released this week with support for Liveview 1.0
  2. For some reason, when you navigate to a page with Alpine.JS component (Input -> Dropdown) it causes some error from AlpineJS. When you load the page with AlpineJS directly it works fine. I wasn't able to find a fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant