From 8d28a750fb686821dd80603de9a1dc9107f6d19d Mon Sep 17 00:00:00 2001 From: Amanda Vialva Date: Tue, 30 Jul 2024 11:42:26 -0400 Subject: [PATCH 1/4] chore: add cluster name title Co-authored-by: Corban corban.beaird@hpe.com --- webui/react/src/components/WorkspaceCreateModal.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/webui/react/src/components/WorkspaceCreateModal.tsx b/webui/react/src/components/WorkspaceCreateModal.tsx index 7d0b649bf15..80c652bcf90 100644 --- a/webui/react/src/components/WorkspaceCreateModal.tsx +++ b/webui/react/src/components/WorkspaceCreateModal.tsx @@ -198,7 +198,7 @@ const WorkspaceCreateModalComponent: React.FC = ({ onClose, workspaceId } <> {resourceManagers.map((name) => ( - + Date: Wed, 31 Jul 2024 15:22:39 -0400 Subject: [PATCH 2/4] change helm additional_rm.name to additional_rm.cluster_name --- helm/charts/determined/values.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/helm/charts/determined/values.yaml b/helm/charts/determined/values.yaml index 4ad3b9b20e1..883c2263dab 100644 --- a/helm/charts/determined/values.yaml +++ b/helm/charts/determined/values.yaml @@ -363,7 +363,7 @@ resourcePools: # - resource_manager: # type: kubernetes # max_slots_per_pod: 1 -# name: carolina-multirm-1 +# cluster_name: carolina-multirm-1 # default_namespace: default # kubeconfig_secret_name: additionalrm # kubeconfig_secret_value: config From c31bd40929891cf3b44fbe137d8816d55f358bbb Mon Sep 17 00:00:00 2001 From: Amanda Vialva Date: Wed, 31 Jul 2024 16:59:48 -0400 Subject: [PATCH 3/4] use template literal for cluster name chnage --- webui/react/src/components/WorkspaceCreateModal.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/webui/react/src/components/WorkspaceCreateModal.tsx b/webui/react/src/components/WorkspaceCreateModal.tsx index 80c652bcf90..40e89bcb86b 100644 --- a/webui/react/src/components/WorkspaceCreateModal.tsx +++ b/webui/react/src/components/WorkspaceCreateModal.tsx @@ -198,7 +198,7 @@ const WorkspaceCreateModalComponent: React.FC = ({ onClose, workspaceId } <> {resourceManagers.map((name) => ( - + Date: Thu, 1 Aug 2024 09:41:38 -0400 Subject: [PATCH 4/4] change rm.cluster_name default value --- helm/charts/determined/values.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/helm/charts/determined/values.yaml b/helm/charts/determined/values.yaml index 883c2263dab..6a578bab802 100644 --- a/helm/charts/determined/values.yaml +++ b/helm/charts/determined/values.yaml @@ -363,7 +363,7 @@ resourcePools: # - resource_manager: # type: kubernetes # max_slots_per_pod: 1 -# cluster_name: carolina-multirm-1 +# cluster_name: additional-cluster # default_namespace: default # kubeconfig_secret_name: additionalrm # kubeconfig_secret_value: config