Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change 'close' to 'save' on button in ManageJob modal [DET-10446] #9746

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

corban-beaird
Copy link
Contributor

@corban-beaird corban-beaird commented Jul 29, 2024

Ticket

DET-10446

Description

Modify text in the ManageJob confirmation to say 'save' instead of 'close' in order to clarify the effect of pressing that button.

Test Plan

  • Ensure that the ManageJob modal shows 'Save' instead of 'Close'

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@corban-beaird corban-beaird requested a review from a team as a code owner July 29, 2024 19:00
@cla-bot cla-bot bot added the cla-signed label Jul 29, 2024
Copy link

netlify bot commented Jul 29, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 117ccc8
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66a7e6cf41f0a50008a09089
😎 Deploy Preview https://deploy-preview-9746--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 49.79%. Comparing base (0df7ad3) to head (117ccc8).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9746      +/-   ##
==========================================
- Coverage   54.12%   49.79%   -4.33%     
==========================================
  Files        1257      934     -323     
  Lines      154768   125438   -29330     
  Branches     3479     3478       -1     
==========================================
- Hits        83762    62460   -21302     
+ Misses      70860    62832    -8028     
  Partials      146      146              
Flag Coverage Δ
harness ?
web 53.39% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
webui/react/src/pages/JobQueue/ManageJob.tsx 0.00% <0.00%> (ø)

... and 323 files with indirect coverage changes

@corban-beaird corban-beaird added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Jul 29, 2024
@corban-beaird corban-beaird merged commit ae31661 into main Jul 29, 2024
91 of 104 checks passed
@corban-beaird corban-beaird deleted the corban/fix-queue-modal-text branch July 29, 2024 20:06
github-actions bot pushed a commit that referenced this pull request Jul 29, 2024
@dannysauer dannysauer restored the corban/fix-queue-modal-text branch July 29, 2024 20:19
@dannysauer dannysauer deleted the corban/fix-queue-modal-text branch July 29, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants